This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Updating SQLDB module bind/unbind to use admin credentials from manif… #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ing test-matrix2 file. Ignoring camel case issues in test file
|
LGTM. And the integration test also passed in my side. Merging. Thanks for contribution! |
zhongyi-zhang
approved these changes
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLDB module is now switched to using the administratorLogin and administratorPasswrod from the AZURE_SQLDB_SQL_SERVER_POOL property during bind and unbind operations.
Note: The design and implementation were discussed with Zhongyi Zhang. Implemented as partof Plato Team at Scotiabank.