Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sideEffects": false for webpack 4 #181

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Conversation

RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Aug 2, 2018

When bundling a sample I found this flag prevented webpack from including a redundant copy of the runtime in the bundle.

When constructing my sample I found this flag prevented webpack from including a redundant copy of the runtime in the bundle.
@RikkiGibson
Copy link
Member Author

Thanks to @TheLarkInn for the tip

@RikkiGibson RikkiGibson merged commit 3ff6c8c into master Aug 3, 2018
@RikkiGibson RikkiGibson deleted the RikkiGibson-patch-1 branch August 3, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant