Set tranformResponse property of axios req. config to an identity function #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
added a commit
to daviwil/azure-sdk-for-js
that referenced
this pull request
Jun 5, 2019
4 tasks
daviwil
added a commit
to daviwil/azure-sdk-for-js
that referenced
this pull request
Jun 6, 2019
daviwil
added a commit
to daviwil/azure-sdk-for-js
that referenced
this pull request
Jun 6, 2019
daviwil
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jun 6, 2019
…actions (#3449) * Add new @azure/identity library and @azure/core-http abstractions * Add CI configuration for @azure/identity * Fix linter errors * Exclude ClientCertificateCredential for now * Move getDefaultAzureCredential to index.ts * Fix OAuth access token request * Remove CredentialScopes type * Add token refresh logic and tests for AzureCredential * Fix wrong path in ci.yml * Correct TokenCredential.getToken doc string * AggregateCredential should break when token is found * Remove refreshBufferMs from IdentityClientOptions * Remove AzureCredential from public exports * Rename AzureCredential's getTokenCore to getAccessToken * Add EnvironmentCredential and ClientSecretCredential tests * Add missing copyright headers in source files * Run Prettier on all source files * Migrate ms-rest-js changes from PR Azure/ms-rest-js#358 * Add basic usage examples to README.md * Add integration information for SDK authors * Propagate abortSignal to getToken correctly * Update description and keywords in package.json * Re-export TokenCredential and RequestOptionsBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axioschanged the way it treats properties of the request config in0.19.0. Previously we were settingtrasnformResponsetoundefined. This would indicateaxiosto not transform (JSON.parse()) the response body. In0.19.0, they are setting the default response transformer if transformResponse is set toundefined. This breaks our pasrsing logic where we are doingJSON.parse()onoperationResponse.bodyAsText. Moreover, we are exposing thebodyAsTextproperty in the generated clients.Not populating this property or setting the value of this property to a parsed JSON would be a breaking change for our users.
Hence we are setting the
transformResponseproperty in the request config to an indentity function that returns the response body as-is.