[generate-examples] Include Min/Max in default example titles #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikeharder
commented
Oct 15, 2024
•
mikeharder
commented
- Fixes oav generate-examples generated min and max sets with same title #935
- Uses unique titles when first generating examples
- Still has unrelated bugs where title can be changed when updating existing examples
mikeharder
commented
Oct 15, 2024
| @@ -186,7 +186,7 @@ export default class Generator { | |||
| ? specItem.content.summary | |||
| : specItem.content.description | |||
| ? specItem.content.description | |||
| : operationId, | |||
| : `${operationId}_${rule.exampleNamePostfix}`, | |||
There was a problem hiding this comment.
Similar to pattern used for example filenames
mikeharder
changed the title
scbedd
approved these changes
Oct 15, 2024
dargilco
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.