Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write status file on Disable, Update. Create dummy status files during update if needed. #37

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

vivlingaiah
Copy link
Contributor

  • Do not write status file on Disable, Update. These two operations have been overwriting the status of previously executed Run command. So, not writing status files in these two operations will make status related to last execution (last enable ) available even after Update.
  • Create dummy status files with status "success" corresponding to those .mrseq files that do not have status files during update. This is to temporarily correct the agent behavior where older agent versions delete the status file on disable during upgrade. After upgrade, there will be poll status timeouts without the status files for previously executed Run Commands. So, these dummy status files help fix that. Latest agent has fixed the issue. However, we need these dummy status files until old agent versions are being used in Production.
  • Currently, timeouts are not an issue in production. This is a change in response to changes in agent where agent stopped removing the status files. Dummy status files are needed for older agents that are still in production, because older agents delete the status files in Disable operation that's part of upgrade.

internal/cmds/cmds.go Outdated Show resolved Hide resolved
internal/cmds/cmds.go Outdated Show resolved Hide resolved
internal/cmds/cmds.go Show resolved Hide resolved
internal/cmds/cmds.go Outdated Show resolved Hide resolved
@vivlingaiah vivlingaiah merged commit 71f12d4 into main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants