Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing fullnameOverride to helm chart #760

Merged
merged 3 commits into from
Jan 25, 2022
Merged

fix: Add missing fullnameOverride to helm chart #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
154e512
fix: Add missing fullnameOverride to helm chart
nxf5025 Jan 19, 2022
0d76197
Merge branch 'master' into bugfix/add-missing-fullnameoverride
aramase Jan 21, 2022
7abfe60
Merge branch 'master' into bugfix/add-missing-fullnameoverride
aramase Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifest_staging/charts/csi-secrets-store-provider-azure/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: csi-secrets-store-provider-azure
version: 1.0.1
version: 1.0.2
appVersion: 1.0.1
kubeVersion: ">=1.16.0-0"
description: A Helm chart to install the Secrets Store CSI Driver and the Azure Keyvault Provider inside a Kubernetes cluster.
Expand Down
4 changes: 4 additions & 0 deletions manifest_staging/charts/csi-secrets-store-provider-azure/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
If release name contains chart name it will be used as a full name.
*/}}
{{- define "sscdpa.fullname" -}}
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}
{{- end -}}

{{/*
Standard labels for helm resources
Expand Down
3 changes: 3 additions & 0 deletions manifest_staging/charts/csi-secrets-store-provider-azure/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
nameOverride: ""
fullnameOverride: ""

# Values populated by Azure Arc K8s RP during the installation of the extension.
Azure:
proxySettings:
Expand Down