Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action input to set download base url #113

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Add action input to set download base url #113

merged 4 commits into from
Jan 2, 2024

Conversation

paulvollmer
Copy link
Contributor

What?

Add an action input to set download base url.

Why?

The initial feature request was done in the issue #110 .

@paulvollmer paulvollmer requested a review from a team as a code owner June 25, 2023 21:07
@paulvollmer
Copy link
Contributor Author

@microsoft-github-policy-service agree

OliverMKing
OliverMKing previously requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Left one comment. Thanks for the work.

src/run.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the stale 90 days old label Jul 13, 2023
@paulvollmer
Copy link
Contributor Author

@OliverMKing can you have a look one more time to this PR please.

@github-actions github-actions bot removed the stale 90 days old label Jul 23, 2023
@thomas-z-meyer-db thomas-z-meyer-db mentioned this pull request Jul 26, 2023
Closed
@github-actions github-actions bot added the stale 90 days old label Aug 15, 2023
@paulvollmer
Copy link
Contributor Author

paulvollmer commented Aug 28, 2023 •
edited
Loading

@microsoftopensource who else can review the latest changes?

@github-actions github-actions bot removed the stale 90 days old label Aug 28, 2023
@github-actions github-actions bot added the stale 90 days old label Sep 11, 2023
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Sep 25, 2023
@github-actions github-actions bot added the stale 90 days old label Oct 10, 2023
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Oct 24, 2023
@github-actions github-actions bot added the stale 90 days old label Nov 7, 2023
@github-actions GitHub Actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old labels Nov 21, 2023
@github-actions github-actions bot removed the idle Inactive for 14 days label Nov 21, 2023
@github-actions github-actions bot added the stale 90 days old label Dec 5, 2023
@github-actions GitHub Actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Dec 19, 2023
@paulvollmer
Copy link
Contributor Author

@OliverMKing or @jaiveerk can we please merge the PR.

Tatsinnit
Tatsinnit approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉👍

@jaiveerk jaiveerk dismissed OliverMKing’s stale review December 29, 2023 18:00

Dismissing review, as requested changes have been implemented. Reviewer requested that URL package be used "to handle merging the path and baseurl", which is now being accomplished in line 134 of run.ts

@jaiveerk
Copy link

hey @paulvollmer, thanks so much for your contribution and for your patience here.

I've gone ahead and dismissed @OliverMKing's review to unblock you from merging, but would you mind signing your commits? It's a requirement for Azure Open-Source Repos. Check out this page that github links for information on this process. Thanks!

davidgamero
davidgamero approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidgamero davidgamero merged commit d336b89 into Azure:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiveerk jaiveerk jaiveerk approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@davidgamero davidgamero davidgamero approved these changes

@OliverMKing OliverMKing Awaiting requested review from OliverMKing

Assignees

@paulvollmer paulvollmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulvollmer @jaiveerk @davidgamero @Tatsinnit @OliverMKing