Updated LLDP startup configuration for multi-asic (#15440) #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did: Changes in LLDP Configuration to handle this: Enable LLDP only on front panel interfaces. Why I did: This is done to free up CPU cycle as we don't see use for that in multi-asic and also for Chassis we have disable lldp docker on supervisor so there is no lldp peering even if send LLDP BPDU on backplane ports For multi-asic do not generate lldpd.conf with eth0 related configuration Why I did: In namespace lldp docker there is no need to generate eth0 configuration. It gives not needed errror message as seen here sonic-net/sonic-buildimage#15382 How I did it: Instead of relying on DEVICE_METADTA sub_role we are using NAMESPACE_ID environmental variable (passed to all docker instance) which will be > 0 for multiasic docker instance and not define for global/host docker instance. --------- Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@vmittal-msft @judyjoseph please review |
|
@saksarav-nokia for viz. |
|
@gechiang to help with merge |
judyjoseph
approved these changes
Jun 28, 2024
vmittal-msft
approved these changes
Jun 28, 2024
gechiang
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR: sonic-net/sonic-buildimage#15440
ADO: 28702813
Why I did:
To fix MC Replication error on DNX Platform when we send LLDP frame on Inband/Recirc Ports.