Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a further code clean up on top of PR #3880 #3927

Open
yxieca opened this issue Dec 18, 2019 · 0 comments
Open

Propose a further code clean up on top of PR #3880 #3927

yxieca opened this issue Dec 18, 2019 · 0 comments

Comments

@yxieca
Copy link
Contributor

yxieca commented Dec 18, 2019

This is not an issue. But rather an enhancement request.

With PR #3880 merged. We have a better calculation of reboot cause in different sequence of hardware/software reboot.

I propose to further clean up the calculation/processing code to following structure:

calculate command line (/proc/cmdline) reason.
calculate software reason.
calculate hardware reason.

Each calculation logs the particular sub reason.

After all 3 reason got collected, calculate the final reason according to the current algorithm.

Benefit: having a clear decision trace. If we had doubt/issue in the future. all the evidence and decision chain can be found in syslog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant