[process-reboot-cause]Clean up the process-reboot-cause #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
yxieca
approved these changes
Feb 11, 2020
abdosi
pushed a commit
that referenced
this pull request
Feb 14, 2020
yxieca
pushed a commit
that referenced
this pull request
Feb 14, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Feb 26, 2020
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Clean up the process-reboot-cause as mentioned in Propose a further code clean up on top of PR #3880
- How I did it
Calculate command line (/proc/cmdline) reason and log.
Calculate hardware reason and log.
Calculate software reason and log
Decide the final reboot cause in the following logic:
If there is a /proc/cmdline reboot cause, use the software reason as the reboot cause;
elif there is a hardware reason, treat it as the reboot cause
else treat the software reason as the reboot cause.
- How to verify it
reboot and check the reboot cause in the following order:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)