-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add incremental QOS config tests #4580
Conversation
PR description has a link to a personal forked repo. Could you use the link in Azure repo and master branch? In reply to: 954437006 |
|
||
yield | ||
|
||
verifyOrchagentRunningOrAssert(duthost) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is a relevant script we may use that needs to be validated before using in our test. I will follow up with Neetha.
@isabelmsft In PR description, this change is related with YANG model. Is it OK to merge this PR now? Will it fail on 202012 or master branch? |
Yes, it's okay to merge now since Mohamed added the option to ignore problematic YANG models. \ Neetha has now shared the formulas for calculating proper field values (as opposed to the arbitrary values used in this PR). I have finished updating the test with proper field values. After merging this, I will open a new PR which uses the formulas so that those changes are easier to distinguish and review. |
Description of PR
This PR will remain in draft mode until YANG model validation errors are resolved. Presently, the test case only runs successfully when the following YANG models are manually removed:
sonic-bgp-neighbor.yang
sonic-device_metadata.yang
sonic-feature.yang
sonic-flex_counter.yang
sonic-scheduler.yang
sonic-queue.yang
sonic-buffer-port-egress-profile-list.yang
sonic-buffer-port-ingress-profile-list.yang
Summary: Testcases of incremental qos configs for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation