Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule update] SAI submodule update #1023

Merged
merged 7 commits into from
Mar 31, 2022

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Mar 23, 2022

Signed-off-by: bingwang bingwang@microsoft.com

Changes include

- d0f3333 Tunnel Scoped TC MAP and Remarking (#1413) (#1451)
- 62364a3 Add two more API as RPC for warmboot testing (#1421) (#1437)
- 426fad1 Make saithriftv compatible with thrift 0.14.1 (#1433)

Also update sai_redis_tunnel and sai_vs_tunnel to fix build issue.

Signed-off-by: bingwang <bingwang@microsoft.com>
@kcudnik
Copy link
Collaborator

kcudnik commented Mar 23, 2022

please fix errors

sai_redis_tunnel.cpp:16:1: error: missing initializer for member '_sai_tunnel_api_t::get_tunnels_attribute' [-Werror=missing-field-initializers]
 };
 ^
sai_redis_tunnel.cpp:16:1: error: missing initializer for member '_sai_tunnel_api_t::set_tunnels_attribute' [-Werror=missing-field-initializers]

Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms
Copy link
Contributor Author

@kcudnik Could you please to check again? I fixed the build error, but PR testing was blocked by code coverage. The uncovered lines are function declaration

REDIS_BULK_GET_SET
VS_BULK_GET_SET

I attempted to add UT for it, but UT also failed. Any hint?

@kcudnik
Copy link
Collaborator

kcudnik commented Mar 29, 2022

those apis would need to be called in the unittests, just as dummy, just to execute code. look at similar apis if you want yo fix this, but for this PR we can ignore this and make the merge

kcudnik
kcudnik previously approved these changes Mar 30, 2022
Signed-off-by: bingwang <wang.bing@microsoft.com>
@bingwang-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit 473c990 into sonic-net:master Mar 31, 2022
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
* SAI submodule update

- d0f3333 Tunnel Scoped TC MAP and Remarking (sonic-net#1413) (sonic-net#1451)
- 62364a3 Add two more API as RPC for warmboot testing (sonic-net#1421) (sonic-net#1437)
- 426fad1 Make saithriftv compatible with thrift 0.14.1 (sonic-net#1433)

Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants