-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437
Open
stephenxs
wants to merge
5
commits into
sonic-net:master
Choose a base branch
from
stephenxs:not-poll-bulk-init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
stephenxs
force-pushed
the
not-poll-bulk-init
branch
from
October 21, 2024 04:13
0f24502
to
fd01720
Compare
kcudnik
reviewed
Oct 21, 2024
kcudnik
previously approved these changes
Oct 21, 2024
stephenxs
force-pushed
the
not-poll-bulk-init
branch
2 times, most recently
from
October 22, 2024 02:07
67b848a
to
8e61f47
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
not-poll-bulk-init
branch
from
October 24, 2024 14:15
8e61f47
to
fe901a9
Compare
@kcudnik I added UT to meet coverage. |
UT failed due to a conflict with another PR. Fixing. |
stephenxs
force-pushed
the
not-poll-bulk-init
branch
from
October 28, 2024 10:35
3786454
to
a41bb9d
Compare
kcudnik
approved these changes
Oct 28, 2024
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…s supported Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
not-poll-bulk-init
branch
from
November 2, 2024 04:54
a41bb9d
to
380d54e
Compare
Same infra issue as that in another PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option
CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups