Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437

stephenxs · 2024-10-20T14:02:11Z

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option

Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups
Generate CLI options to syncd
Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization

kcudnik

see comments

syncd/CommandLineOptions.cpp

syncd/FlexCounter.cpp

syncd/FlexCounter.h

syncd/CommandLineOptionsParser.cpp

kcudnik · 2024-10-23T10:08:01Z

/azp run

azure-pipelines · 2024-10-23T10:08:13Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2024-10-25T02:33:01Z

@kcudnik I added UT to meet coverage.

stephenxs · 2024-10-25T07:11:57Z

UT failed due to a conflict with another PR. Fixing.

stephenxs · 2024-11-04T02:26:07Z

Same infra issue as that in another PR

vslib/.libs'
+ for dir in ${gcov_dirs}
++ dirname common/.libs
+ source_dir=common
+ output_file=coverage-common.json
+ gcovr --exclude-unreachable-branches --json-pretty -o coverage-common.json --object-directory common common/.libs
+ for dir in ${gcov_dirs}
++ dirname common/c-api/.libs
+ source_dir=common/c-api
+ output_file=coverage-common/c-api.json
+ gcovr --exclude-unreachable-branches --json-pretty -o coverage-common/c-api.json --object-directory common/c-api common/c-api/.libs
usage: gcovr [options] [search_paths...]
gcovr: error: argument -o/--output: Could not create output file 'coverage-common/c-api.json': No such file or directory

Signed-off-by: Stephen Sun <stephens@nvidia.com>

…s supported Signed-off-by: Stephen Sun <stephens@nvidia.com>

Signed-off-by: Stephen Sun <stephens@nvidia.com>

…hat support bulk per CLI option (sonic-net#1437) Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups Generate CLI options to syncd Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization

bingwang-ms · 2024-11-20T21:28:15Z

@kcudnik Can you please confirm if this PR is required for 202405?

kcudnik · 2024-11-21T06:52:49Z

@bingwang-ms please ask @stephenxs to confirm

stephenxs · 2024-11-21T11:10:24Z

@bingwang-ms please ask @stephenxs to confirm

Yes, we need it in 202405. @bingwang-ms

…hat support bulk per CLI option (sonic-net#1437) Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups Generate CLI options to syncd Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization

mssonicbld · 2024-12-02T22:01:01Z

Cherry-pick PR to 202405: #1478

…hat support bulk per CLI option (#1437) Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups Generate CLI options to syncd Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization

…hat support bulk per CLI option (sonic-net#1437) Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option Read the counter groups that support bulk mode from CONFIG_DB.DEVICE_METADATA|localhost.supporting_bulk_counter_groups Generate CLI options to syncd Based on CLI options syncd records the counter groups that support bulk mode. For those objects, we do not need to poll them in bulk mode during initialization

DavidZagury added the Request for 202405 Branch label Oct 20, 2024

kcudnik requested changes Oct 20, 2024

View reviewed changes

stephenxs requested a review from kcudnik October 21, 2024 04:13

stephenxs force-pushed the not-poll-bulk-init branch from 0f24502 to fd01720 Compare October 21, 2024 04:13

kcudnik reviewed Oct 21, 2024

View reviewed changes

syncd/CommandLineOptionsParser.cpp Outdated Show resolved Hide resolved

stephenxs requested a review from kcudnik October 21, 2024 07:44

kcudnik previously approved these changes Oct 21, 2024

View reviewed changes

stephenxs force-pushed the not-poll-bulk-init branch 2 times, most recently from 67b848a to 8e61f47 Compare October 22, 2024 02:07

stephenxs force-pushed the not-poll-bulk-init branch from 8e61f47 to fe901a9 Compare October 24, 2024 14:15

stephenxs dismissed kcudnik’s stale review via 3786454 October 25, 2024 02:02

stephenxs requested a review from kcudnik October 25, 2024 02:04

stephenxs force-pushed the not-poll-bulk-init branch from 3786454 to a41bb9d Compare October 28, 2024 10:35

kcudnik approved these changes Oct 28, 2024

View reviewed changes

stephenxs force-pushed the not-poll-bulk-init branch from a41bb9d to 380d54e Compare November 2, 2024 04:54

stephenxs added 5 commits November 6, 2024 18:16

Refactor the logic to map counter type from plugin

90c944d

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Do not poll counters in bulk mode during initialization if the bulk i…

3b26dcb

…s supported Signed-off-by: Stephen Sun <stephens@nvidia.com>

Fix review comments

c861a3e

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Fix comments

4ba0d3b

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Fix coverage

e0f8b07

Signed-off-by: Stephen Sun <stephens@nvidia.com>

stephenxs force-pushed the not-poll-bulk-init branch from 380d54e to e0f8b07 Compare November 6, 2024 10:17

kcudnik merged commit c4aea50 into sonic-net:master Nov 7, 2024
18 checks passed

stephenxs deleted the not-poll-bulk-init branch November 7, 2024 08:38

ZhaohuiS mentioned this pull request Nov 28, 2024

modify syncd init script for supporting yml #1411

Closed

bingwang-ms added the Approved for 202405 Branch label Dec 2, 2024

mssonicbld mentioned this pull request Dec 2, 2024

[action] [PR:1437] Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option (#1437) #1478

Merged

mssonicbld added the Created PR to 202405 Branch label Dec 2, 2024

mssonicbld added Included in 202405 Branch and removed Created PR to 202405 Branch labels Dec 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437

stephenxs commented Oct 20, 2024

kcudnik left a comment

kcudnik commented Oct 23, 2024

azure-pipelines bot commented Oct 23, 2024

stephenxs commented Oct 25, 2024

stephenxs commented Oct 25, 2024

stephenxs commented Nov 4, 2024

bingwang-ms commented Nov 20, 2024

kcudnik commented Nov 21, 2024

stephenxs commented Nov 21, 2024

mssonicbld commented Dec 2, 2024

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437

Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option #1437

Conversation

stephenxs commented Oct 20, 2024

kcudnik left a comment

Choose a reason for hiding this comment

kcudnik commented Oct 23, 2024

azure-pipelines bot commented Oct 23, 2024

stephenxs commented Oct 25, 2024

stephenxs commented Oct 25, 2024

stephenxs commented Nov 4, 2024

bingwang-ms commented Nov 20, 2024

kcudnik commented Nov 21, 2024

stephenxs commented Nov 21, 2024

mssonicbld commented Dec 2, 2024