[orchagent, SRv6]: create seglist support to set sid list type #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user doesn't set the sid list type, type will be ENCAPS_RED What I did create seglist support to set sid list type Why I did it could not set different sidlist type under local testing How I verified it set different sidlist type of seg list and confirm it works under local testing Signed-off-by: link_chiang <link_chiang@edge-core.com>
|
|
|
Hi @prsunny |
kperumalbfn
reviewed
Dec 5, 2022
| if (fvField(i) == "type") | ||
| { | ||
| sidlist_type = fvValue(i); | ||
| } |
There was a problem hiding this comment.
could you update doc/swss-schema.md with the new attribute 'type' in SRV6_SID_LIST_TABLE
There was a problem hiding this comment.
have updated the swss-schema.md for new attribute 'type' in SRV6_SID_LIST_TABLE
There was a problem hiding this comment.
@kperumalbfn please help review, thanks.
| if (fvField(i) == "type") | ||
| { | ||
| sidlist_type = fvValue(i); | ||
| } |
There was a problem hiding this comment.
could you update test_srv6.py with this new 'path' attribute in the APP_DB.
There was a problem hiding this comment.
have added test case for sidlist_type.
There was a problem hiding this comment.
@kperumalbfn please help review, thanks.
kperumalbfn
approved these changes
Feb 28, 2023
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-swss submodule pointer to include the following: * a2c9a61 [EVPN]Handling error scenarios during route programming and IMR add ([sonic-net#2670](sonic-net/sonic-swss#2670)) * 115efe8 [bfdorch] add default TOS value for BFD session ([sonic-net#2689](sonic-net/sonic-swss#2689)) * a198289 [orchagent, SRv6]: create seglist support to set sid list type ([sonic-net#2406](sonic-net/sonic-swss#2406)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
8 tasks
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Mar 14, 2023
Update sonic-swss submodule pointer to include the following: * 98a16cf [ACL] Write ACL table/rule creation status into STATE_DB ([sonic-net#2662](sonic-net/sonic-swss#2662)) * a2c9a61 [EVPN]Handling error scenarios during route programming and IMR add ([sonic-net#2670](sonic-net/sonic-swss#2670)) * 115efe8 [bfdorch] add default TOS value for BFD session ([sonic-net#2689](sonic-net/sonic-swss#2689)) * a198289 [orchagent, SRv6]: create seglist support to set sid list type ([sonic-net#2406](sonic-net/sonic-swss#2406)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
prsunny
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 14, 2023
Update sonic-swss submodule pointer to include the following: * 98a16cf [ACL] Write ACL table/rule creation status into STATE_DB ([#2662](sonic-net/sonic-swss#2662)) * a2c9a61 [EVPN]Handling error scenarios during route programming and IMR add ([#2670](sonic-net/sonic-swss#2670)) * 115efe8 [bfdorch] add default TOS value for BFD session ([#2689](sonic-net/sonic-swss#2689)) * a198289 [orchagent, SRv6]: create seglist support to set sid list type ([#2406](sonic-net/sonic-swss#2406))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user doesn't set the sid list type, type will be ENCAPS_RED
What I did
create seglist support to set sid list type
Why I did it
could not set different sidlist type under local testing
How I verified it
set different sidlist type of seg list and confirm it works under local testing
Signed-off-by: link_chiang link_chiang@edge-core.com