Suppress Cable length errors in case pg profile lookup file is not provided #509

zhenggen-xu · 2018-05-21T06:46:28Z

What I did
Suppress the error messages like below
May 19 07:39:02.473125 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet0. Cable length is not set
If we don't have pg_profile_lookup.ini file provided.

Why I did it
In some platform, pg_profile_lookup.ini is not provided and we don't need this buffer management feature.

Today the code is repeating these messages:
May 19 07:39:02.473125 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet0. Cable length is not set
May 19 07:39:02.473362 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet1. Cable length is not set
May 19 07:39:02.473558 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet10. Cable length is not set
May 19 07:39:02.473717 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet100. Cable length is not set
May 19 07:39:02.473872 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet102. Cable length is not set
May 19 07:39:02.474061 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet104. Cable length is not set
May 19 07:39:02.474248 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet106. Cable length is not set
May 19 07:39:02.474404 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet108. Cable length is not set
May 19 07:39:02.474557 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet11. Cable length is not set
May 19 07:39:02.474710 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet110. Cable length is not set
May 19 07:39:02.474864 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet112. Cable length is not set
May 19 07:39:02.475018 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet114. Cable length is not set
May 19 07:39:02.475171 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet116. Cable length is not set
May 19 07:39:02.475325 sonic NOTICE buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet118. Cable length is not set
We should disable this error messages.

How I verified it
With the fix, no error messages were seen.

Details if related

qiluo-msft · 2018-05-21T18:30:19Z

cfgmgr/buffermgr.cpp

@@ -34,6 +34,7 @@ void BufferMgr::readPgProfileLookupFile(string file)
    ifstream infile(file);
    if (!infile.is_open())
    {
+        m_pgfile_exist = false;
        return;


Should we log an error here?
SWSS_LOG_ERROR #Closed

It is not necessarily an error if we don't need this feature. I can put an NOTICE or WARNING log message here. #Closed

If you are sure the feature is optional, then a WARNING should be ok.

In reply to: 189676820 [](ancestors = 189676820)

qiluo-msft · 2018-05-21T18:30:44Z

cfgmgr/buffermgr.cpp

@@ -34,6 +34,7 @@ void BufferMgr::readPgProfileLookupFile(string file)
    ifstream infile(file);
    if (!infile.is_open())
    {
+        m_pgfile_exist = false;


m_pgfile_exist [](start = 8, length = 14)

m_pgfile_exist [](start = 8, length = 14)

m_pgfile_readable #Closed

qiluo-msft · 2018-05-21T18:42:07Z

cfgmgr/buffermgr.cpp

@@ -34,6 +34,7 @@ void BufferMgr::readPgProfileLookupFile(string file)
    ifstream infile(file);
    if (!infile.is_open())
    {
+        m_pgfile_exist = false;
        return;
    }


assign m_pgfile_exist true here, and you could remove class member initialization in header file.

Either way should do the work, any reason you prefer to put here rather than in the header file?

For better readability.

I don't see any confusion with the initialization in header file. it is easily readable so I kept the code here.

lguohan · 2018-05-23T11:03:19Z

@yxieca , @volodymyrsamotiy , can you review?

yxieca · 2018-05-23T16:57:40Z

cfgmgr/buffermgr.cpp

@@ -34,6 +34,8 @@ void BufferMgr::readPgProfileLookupFile(string file)
    ifstream infile(file);
    if (!infile.is_open())
    {
+        m_pgfile_readable = false;


Do you think m_pgfile_processed a more suitable name for this variable? I would think setting it to false by default, and flip it to true once the file processing is done will serve your purpose better?

The purpose was to check whether the "pg-lookup-file" was there or not, if not, we don't do the buffer settings. It renamed to cover the case where the file somehow not readable.
By looking at the code, there wasn't any exist after this "is_open" check and before the entire function. This means if we had m_pgfile_processed defined, we would have always set it to true after this check. I,E, there was no difference between the current approach and if we had a new naming.
Anyway, I changed it so everybody is happy.

yxieca · 2018-05-24T15:00:54Z

cfgmgr/buffermgr.cpp

@@ -34,6 +34,8 @@ void BufferMgr::readPgProfileLookupFile(string file)
    ifstream infile(file);
    if (!infile.is_open())
    {
+        m_pgfile_processed = false;


Thanks for making the changes.

You can move the above line to the beginning of the function.

vemulabalaji · 2018-07-05T12:29:51Z

Hi,

I am still observing these messages, Let me know if have to do any configuration/something.

Regards,
Balaji

root@sonic:/# show version
SONiC Software Version: SONiC.HEAD.0-bbca583
Distribution: Debian 8.11
Kernel: 3.16.0-5-amd64
Build commit: bbca583
Build date: Wed Jul 4 15:37:15 UTC 2018
Built by: azure@sfsun001

Docker images:
REPOSITORY TAG IMAGE ID SIZE
docker-orchagent-mlnx HEAD.0-bbca583 c3275235b6b6 258.3 MB
docker-orchagent-mlnx latest c3275235b6b6 258.3 MB
docker-teamd HEAD.0-bbca583 558b8a37fd85 258 MB
docker-teamd latest 558b8a37fd85 258 MB
docker-fpm-quagga HEAD.0-bbca583 b15190ec5263 264.8 MB
docker-fpm-quagga latest b15190ec5263 264.8 MB
docker-syncd-mlnx HEAD.0-bbca583 66509e04458e 325.4 MB
docker-syncd-mlnx latest 66509e04458e 325.4 MB
docker-lldp-sv2 HEAD.0-bbca583 da67539a03e0 270.4 MB
docker-lldp-sv2 latest da67539a03e0 270.4 MB
docker-dhcp-relay HEAD.0-bbca583 a070d0601683 253.8 MB
docker-dhcp-relay latest a070d0601683 253.8 MB
docker-database HEAD.0-bbca583 bd7241b8a33c 252.5 MB
docker-database latest bd7241b8a33c 252.5 MB
docker-snmp-sv2 HEAD.0-bbca583 735c4d81fd69 291.4 MB
docker-snmp-sv2 latest 735c4d81fd69 291.4 MB
docker-router-advertiser HEAD.0-bbca583 7f5e7a85cbd7 250.1 MB
docker-router-advertiser latest 7f5e7a85cbd7 250.1 MB
docker-platform-monitor HEAD.0-bbca583 07af655cb03f 281.3 MB
docker-platform-monitor latest 07af655cb03f 281.3 MB

root@sonic:/#
root@sonic:/#

Sep 10 12:43:02.267414 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet104. Cable length is not set
Sep 10 12:43:02.267445 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet108. Cable length is not set
Sep 10 12:43:02.267445 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet112. Cable length is not set
Sep 10 12:43:02.267471 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet116. Cable length is not set
Sep 10 12:43:02.267471 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet12. Cable length is not set
Sep 10 12:43:02.267471 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet120. Cable length is not set
Sep 10 12:43:02.267471 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet124. Cable length is not set
Sep 10 12:43:02.267484 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet128. Cable length is not set
Sep 10 12:43:02.267493 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet132. Cable length is not set
Sep 10 12:43:02.267493 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet136. Cable length is not set
Sep 10 12:43:02.267694 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet140. Cable length is not set
Sep 10 12:43:02.267694 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet144. Cable length is not set
Sep 10 12:43:02.267694 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet148. Cable length is not set
Sep 10 12:43:02.267720 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet152. Cable length is not set
Sep 10 12:43:02.267821 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet156. Cable length is not set
Sep 10 12:43:02.267821 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet16. Cable length is not set
Sep 10 12:43:02.267834 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet160. Cable length is not set
Sep 10 12:43:02.267967 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet164. Cable length is not set
Sep 10 12:43:02.267967 sonic WARNING buffermgrd: :- doSpeedUpdateTask: Unable to create/update PG profile for port Ethernet168. Cable length is not set

vemulabalaji · 2018-10-11T11:01:28Z

Hi,

I am still observing these messages, Let me know if have to do any configuration/something.

Regards,
Balaji

root@sonic:/var/log# show version
SONiC Software Version: SONiC.HEAD.755-b1d290c
Distribution: Debian 9.5
Kernel: 4.9.0-7-amd64
Build commit: b1d290c
Build date: Sun Oct 7 12:32:03 UTC 2018
Built by: johnar@jenkins-worker-3

Docker images:
REPOSITORY TAG IMAGE ID SIZE
docker-orchagent-mlnx HEAD.755-b1d290c 16c4be574fc4 259.7 MB
docker-orchagent-mlnx latest 16c4be574fc4 259.7 MB
docker-syncd-mlnx HEAD.755-b1d290c 2bb04eebbb04 359.8 MB
docker-syncd-mlnx latest 2bb04eebbb04 359.8 MB
docker-lldp-sv2 HEAD.755-b1d290c 2761515e74da 271.1 MB
docker-lldp-sv2 latest 2761515e74da 271.1 MB
docker-dhcp-relay HEAD.755-b1d290c 38ae3c8d2e3e 253.8 MB
docker-dhcp-relay latest 38ae3c8d2e3e 253.8 MB
docker-database HEAD.755-b1d290c 6bcecf4adf8e 252.5 MB
docker-database latest 6bcecf4adf8e 252.5 MB
docker-teamd HEAD.755-b1d290c ba4fa8a65c17 257.7 MB
docker-teamd latest ba4fa8a65c17 257.7 MB
docker-snmp-sv2 HEAD.755-b1d290c 5e689fcca03a 291.3 MB
docker-snmp-sv2 latest 5e689fcca03a 291.3 MB
docker-router-advertiser HEAD.755-b1d290c a6f84225b7b2 250.1 MB
docker-router-advertiser latest a6f84225b7b2 250.1 MB
docker-platform-monitor HEAD.755-b1d290c 48d8a5624d0a 283.5 MB
docker-platform-monitor latest 48d8a5624d0a 283.5 MB
docker-fpm-quagga HEAD.755-b1d290c eab298bf660c 264.6 MB
docker-fpm-quagga latest eab298bf660c 264.6 MB

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* Provide generic stat api to switch object * Add generic api to tam_int * Provide vs generic stat api to vs switch * Add vs generic api to vs tam_int Signed-off-by: Wenda Ni <wenni@microsoft.com>

zhenggen-xu changed the title ~~Suppress Cable length error in case buffer config file is not provided~~ Suppress Cable length error in case pg profile lookup file is not provided May 21, 2018

zhenggen-xu changed the title ~~Suppress Cable length error in case pg profile lookup file is not provided~~ Suppress Cable length errors in case pg profile lookup file is not provided May 21, 2018

zhenggen-xu changed the title ~~Suppress Cable length errors in case pg profile lookup file is not provided~~ Suppress Cable length errors in case pg profile lookup file is not provided May 21, 2018

qiluo-msft reviewed May 21, 2018

View reviewed changes

Suppress Cable length error in case buffer config file is not provided

c4b7c38

zhenggen-xu force-pushed the github-fork branch from 43e9648 to c4b7c38 Compare May 22, 2018 06:25

yxieca reviewed May 23, 2018

View reviewed changes

yxieca reviewed May 24, 2018

View reviewed changes

yxieca approved these changes May 24, 2018

View reviewed changes

fix PR feedback

6449d7d

zhenggen-xu force-pushed the github-fork branch from dd793a5 to 6449d7d Compare May 25, 2018 05:17

yxieca approved these changes May 25, 2018

View reviewed changes

yxieca merged commit 44a8845 into sonic-net:master May 25, 2018

stcheng added the Enhancement ➕ label Nov 3, 2018

zhenggen-xu deleted the github-fork branch October 7, 2019 16:42

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022

Align PSU DB count field with the schema Spec. (sonic-net#509)

fbe4ede

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suppress Cable length errors in case pg profile lookup file is not provided #509

Suppress Cable length errors in case pg profile lookup file is not provided #509

zhenggen-xu commented May 21, 2018

qiluo-msft May 21, 2018 •

edited

Loading

zhenggen-xu May 21, 2018 •

edited by qiluo-msft

Loading

qiluo-msft May 21, 2018

zhenggen-xu May 22, 2018

qiluo-msft May 21, 2018 •

edited

Loading

zhenggen-xu May 22, 2018

qiluo-msft May 21, 2018

zhenggen-xu May 21, 2018

qiluo-msft May 21, 2018

zhenggen-xu May 22, 2018

lguohan commented May 23, 2018

yxieca May 23, 2018

zhenggen-xu May 24, 2018

yxieca May 24, 2018

vemulabalaji commented Jul 5, 2018

vemulabalaji commented Oct 11, 2018

Suppress Cable length errors in case pg profile lookup file is not provided #509

Suppress Cable length errors in case pg profile lookup file is not provided #509

Conversation

zhenggen-xu commented May 21, 2018

qiluo-msft May 21, 2018 • edited Loading

Choose a reason for hiding this comment

zhenggen-xu May 21, 2018 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiluo-msft May 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented May 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vemulabalaji commented Jul 5, 2018

vemulabalaji commented Oct 11, 2018

qiluo-msft May 21, 2018 •

edited

Loading

zhenggen-xu May 21, 2018 •

edited by qiluo-msft

Loading

qiluo-msft May 21, 2018 •

edited

Loading