-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v6.0 and new CI pipeline. #241
Conversation
Update Changelog.
This is how I checked this PR:
the e2e test is failing for me.
|
Do we actually need
|
I understand now that because I was not passing the I tested the e2e tests like this:
all tests passed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # README.md
This is a major version upgrade and it mainly focus on adding a new CI pipeline to this repo so we can speed up our code review and enforce a high code quality standard.
It also split original test fixture folder into three so we can demonstrate different use cases.