Add support for Image Cleaner #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skolobov
changed the title
|
@microsoft-github-policy-service agree |
1 task
skolobov
force-pushed
the
feature/image-cleaner
branch
from
4f3d07c to
1c22fa4
Compare
skolobov
force-pushed
the
feature/image-cleaner
branch
from
1c22fa4 to
23f1d29
Compare
skolobov
force-pushed
the
feature/image-cleaner
branch
from
23f1d29 to
f14ea2f
Compare
lonegunmanb
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks @skolobov for contributing this pr to us and apology for this crazy late response. I'd like to merge this pr as part of v7.5.0, but only one review comment to solve.
| @@ -23,6 +23,8 @@ resource "azurerm_kubernetes_cluster" "main" { | |||
| disk_encryption_set_id = var.disk_encryption_set_id | |||
| dns_prefix = var.prefix | |||
| http_application_routing_enabled = var.http_application_routing_enabled | |||
| image_cleaner_enabled = var.image_cleaner_enabled | |||
| image_cleaner_interval_hours = var.image_cleaner_enabled && var.image_cleaner_interval_hours != null ? var.image_cleaner_interval_hours : null | |||
There was a problem hiding this comment.
Could we use image_cleaner_interval_hours = var.image_cleaner_interval_hours here?
|
Potential Breaking Changes in 86e038e: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for optional Image Cleaner feature in AKS.
Issue number
Fixes #342
Checklist before requesting a review
CHANGELOG.mdfile