Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default empty list for allowed and not_allowed in var.maintenance_window #463

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Issue number

#455

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

…omit them if they don't want such config block
@lonegunmanb lonegunmanb added this to the 7.5.0 milestone Oct 30, 2023
@lonegunmanb lonegunmanb changed the title Add default empty list for allowed and not_allowed Add default empty list for allowed and not_allowed in var.maintenance_window Oct 30, 2023
@github-actions
Copy link
Contributor

Potential Breaking Changes in 547fd7a:
[update] "Variables.maintenance_window.Type" from 'object({
allowed = list(object({
day = string
hours = set(number)
})),
not_allowed = list(object({
end = string
start = string
})),
})' to 'object({
allowed = optional(list(object({
day = string
hours = set(number)
})), []),
not_allowed = optional(list(object({
end = string
start = string
})), []),
})'

@lonegunmanb lonegunmanb temporarily deployed to acctests October 30, 2023 09:15 — with GitHub Actions Inactive
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiaweitao001 jiaweitao001 merged commit b66c2a1 into Azure:main Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants