Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.ContainerService managedClusters API version to 2024-02-01 #552

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Update Microsoft.ContainerService managedClusters API version to 2024-02-01 #552

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c93c5d
Update main.tf
olofmattsson-inriver May 29, 2024
6d2a318
Typo in api version
olofmattsson-inriver May 30, 2024
65e6b40
Merge branch 'Azure:main' into patch/azapi_update_resource_version
olofmattsson-inriver May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ resource "null_resource" "kubernetes_version_keeper" {
}

resource "azapi_update_resource" "aks_cluster_post_create" {
type = "Microsoft.ContainerService/managedClusters@2023-01-02-preview"
type = "Microsoft.ContainerService/managedClusters@2024-02-01"
body = jsonencode({
properties = {
kubernetesVersion = var.kubernetes_version
Expand All @@ -660,7 +660,7 @@ resource "null_resource" "http_proxy_config_no_proxy_keeper" {
resource "azapi_update_resource" "aks_cluster_http_proxy_config_no_proxy" {
count = can(var.http_proxy_config.no_proxy[0]) ? 1 : 0

type = "Microsoft.ContainerService/managedClusters@2023-01-02-preview"
type = "Microsoft.ContainerService/managedClusters@2024-02-01-preview"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've assigned two different API for two aks update resources, do we have any special reason for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other than my ignorance. My test passed so I didn't spot the typo. Updated the PR

body = jsonencode({
properties = {
httpProxyConfig = {
Expand Down