Amend new attributes in network_profile block #585
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -897,6 +897,19 @@ variable "msi_auth_for_monitoring_enabled" { | |||||
| description = "(Optional) Is managed identity authentication for monitoring enabled?" | ||||||
| } | ||||||
|
|
||||||
| variable "nat_gateway_profile" { | ||||||
| type = object({ | ||||||
| idle_timeout_in_minutes = optional(number) | ||||||
| managed_outbound_ip_count = optional(number) | ||||||
| }) | ||||||
| default = null | ||||||
| description = <<-EOT | ||||||
| `nat_gateway_profile` block supports the following: | ||||||
| - `idle_timeout_in_minutes` - (Optional) Desired outbound flow idle timeout in minutes for the cluster load balancer. Must be between `4` and `120` inclusive. Defaults to `4`. | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. @lonegunmanb please review suggestion |
||||||
| - `managed_outbound_ip_count` - (Optional) Count of desired managed outbound IPs for the cluster load balancer. Must be between `1` and `100` inclusive. | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| EOT | ||||||
| } | ||||||
|
|
||||||
| variable "net_profile_dns_service_ip" { | ||||||
| type = string | ||||||
| default = null | ||||||
|
|
@@ -928,6 +941,24 @@ variable "network_contributor_role_assigned_subnet_ids" { | |||||
| nullable = false | ||||||
| } | ||||||
|
|
||||||
| variable "network_data_plane" { | ||||||
| type = string | ||||||
| default = null | ||||||
| description = "(Optional) Specifies the data plane used for building the Kubernetes network. Possible values are `azure` and `cilium`. Defaults to `azure`. Disabling this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "network_ip_versions" { | ||||||
|
There was a problem hiding this comment. We need a precondition that network_plugin_mode is set to overlay |
||||||
| type = list(string) | ||||||
| default = null | ||||||
| description = "(Optional) Specifies a list of IP versions the Kubernetes Cluster will use to assign IP addresses to its nodes and pods. Possible values are `IPv4` and/or `IPv6`. `IPv4` must always be specified. Changing this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "network_mode" { | ||||||
| type = string | ||||||
| default = null | ||||||
| description = "(Optional) Network mode to be used with Azure CNI. Possible values are `bridge` and `transparent`. Changing this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "network_plugin" { | ||||||
| type = string | ||||||
| default = "kubenet" | ||||||
|
|
@@ -941,12 +972,24 @@ variable "network_plugin_mode" { | |||||
| description = "(Optional) Specifies the network plugin mode used for building the Kubernetes network. Possible value is `overlay`. Changing this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "net_profile_pod_cidrs" { | ||||||
| type = list(string) | ||||||
| default = null | ||||||
| description = "(Optional) A list of CIDRs to use for pod IP addresses. For single-stack networking a single IPv4 CIDR is expected. For dual-stack networking an IPv4 and IPv6 CIDR are expected. Changing this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "network_policy" { | ||||||
| type = string | ||||||
| default = null | ||||||
| description = " (Optional) Sets up network policy to be used with Azure CNI. Network policy allows us to control the traffic flow between pods. Currently supported values are calico and azure. Changing this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "net_profile_service_cidrs" { | ||||||
| type = list(string) | ||||||
| default = null | ||||||
| description = "(Optional) A list of CIDRs to use for Kubernetes services. For single-stack networking a single IPv4 CIDR is expected. For dual-stack networking an IPv4 and IPv6 CIDR are expected. Changing this forces a new resource to be created." | ||||||
| } | ||||||
|
|
||||||
| variable "node_os_channel_upgrade" { | ||||||
| type = string | ||||||
| default = null | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a review of this PR I found out that the upstream provider documentation was wrong. Also for the parameters.
I opened a PR here:
https://github.com/hashicorp/terraform-provider-azurerm/pull/27287/files