-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v4
sub-folder so this module could run with AzureRM provider both v3
and v4
.
#594
Conversation
Is this one on the radar? I'm waiting for this module to be ready for V4 so that I can leverage the options V4 has to offer like |
Anything we can do to help move this along? We'd like to update our azurerm provider to 4.x |
The failed action clearly states the problem:
6 hours is GitHub's usage limit. I'd guess splitting up the test into smaller chunks should solve this. |
Hello all, if you have a urgent need to move to azurerm v4, https://github.com/Azure/terraform-azurerm-avm-res-containerservice-managedcluster/ This module is guaranteed to be V4 by the end of January 2025. For the current |
Thanks a lot @philippeckelintive for this comment. I'll try to solve this issue. |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 64 out of 82 changed files in this pull request and generated 1 suggestion.
Files not reviewed (18)
- deprecated_variables.tf: Language not supported
- examples/application_gateway_ingress_v4/data.tf: Language not supported
- examples/application_gateway_ingress_v4/k8s_workload.tf: Language not supported
- examples/application_gateway_ingress_v4/main.tf: Language not supported
- examples/application_gateway_ingress_v4/main_override.tf: Language not supported
- examples/application_gateway_ingress_v4/outputs.tf: Language not supported
- examples/application_gateway_ingress_v4/providers.tf: Language not supported
- examples/application_gateway_ingress_v4/providers_override.tf: Language not supported
- examples/application_gateway_ingress_v4/variables.tf: Language not supported
- examples/multiple_node_pools/main.tf: Language not supported
- examples/multiple_node_pools/main_override.tf: Language not supported
- examples/multiple_node_pools_v4/main.tf: Language not supported
- examples/multiple_node_pools_v4/main_override.tf: Language not supported
- examples/multiple_node_pools_v4/outputs.tf: Language not supported
- examples/multiple_node_pools_v4/providers.tf: Language not supported
- examples/multiple_node_pools_v4/providers_override.tf: Language not supported
- examples/multiple_node_pools_v4/variables.tf: Language not supported
- examples/named_cluster/main.tf: Language not supported
Describe your changes
This pr added
v4
sub-folder and referenced all.tf
files via symbolic link, and patch resources by adding Terraform override files, so the users who'd like to use AzureRMv4
could do it by setting module'ssource
toAzure/aks/azurerm//v4
.Issue number
#000
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!