Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v4 sub-folder so this module could run with AzureRM provider both v3 and v4. #594

Merged
merged 22 commits into from
Dec 10, 2024

Conversation

lonegunmanb
Copy link
Member

Describe your changes

This pr added v4 sub-folder and referenced all .tf files via symbolic link, and patch resources by adding Terraform override files, so the users who'd like to use AzureRM v4 could do it by setting module's source to Azure/aks/azurerm//v4.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@Glaaj
Copy link

Glaaj commented Nov 12, 2024

Is this one on the radar? I'm waiting for this module to be ready for V4 so that I can leverage the options V4 has to offer like service endpoints on a vnet..

@johnknutsonhc
Copy link

Anything we can do to help move this along? We'd like to update our azurerm provider to 4.x

@philippeckelintive
Copy link

The failed action clearly states the problem:

end to end / acc-tests
The job running on runner GitHub Actions 784 has exceeded the maximum execution time of 360 minutes.

6 hours is GitHub's usage limit.

I'd guess splitting up the test into smaller chunks should solve this.

@zioproto
Copy link
Collaborator

Hello all,

if you have a urgent need to move to azurerm v4,
my suggestion is to look into this new Microsoft AKS resource module, that is part of the AVM initiative:

https://github.com/Azure/terraform-azurerm-avm-res-containerservice-managedcluster/

This module is guaranteed to be V4 by the end of January 2025.

For the current terraform-azurerm-aks module, we don't have a clear plan for the upgrade.
We might come up with some instructions to migrate to the AVM module, but there is nothing decided yet.

Cc: @ibersanoMS @nellyk @lonegunmanb

@lonegunmanb
Copy link
Member Author

The failed action clearly states the problem:

end to end / acc-tests
The job running on runner GitHub Actions 784 has exceeded the maximum execution time of 360 minutes.

6 hours is GitHub's usage limit.

I'd guess splitting up the test into smaller chunks should solve this.

Thanks a lot @philippeckelintive for this comment. I'll try to solve this issue.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 64 out of 82 changed files in this pull request and generated 1 suggestion.

Files not reviewed (18)
  • deprecated_variables.tf: Language not supported
  • examples/application_gateway_ingress_v4/data.tf: Language not supported
  • examples/application_gateway_ingress_v4/k8s_workload.tf: Language not supported
  • examples/application_gateway_ingress_v4/main.tf: Language not supported
  • examples/application_gateway_ingress_v4/main_override.tf: Language not supported
  • examples/application_gateway_ingress_v4/outputs.tf: Language not supported
  • examples/application_gateway_ingress_v4/providers.tf: Language not supported
  • examples/application_gateway_ingress_v4/providers_override.tf: Language not supported
  • examples/application_gateway_ingress_v4/variables.tf: Language not supported
  • examples/multiple_node_pools/main.tf: Language not supported
  • examples/multiple_node_pools/main_override.tf: Language not supported
  • examples/multiple_node_pools_v4/main.tf: Language not supported
  • examples/multiple_node_pools_v4/main_override.tf: Language not supported
  • examples/multiple_node_pools_v4/outputs.tf: Language not supported
  • examples/multiple_node_pools_v4/providers.tf: Language not supported
  • examples/multiple_node_pools_v4/providers_override.tf: Language not supported
  • examples/multiple_node_pools_v4/variables.tf: Language not supported
  • examples/named_cluster/main.tf: Language not supported

README.md Outdated Show resolved Hide resolved
@lonegunmanb lonegunmanb merged commit f57085f into main Dec 10, 2024
5 checks passed
@lonegunmanb lonegunmanb deleted the v4 branch December 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants