Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of oms_agent_enabled add-on #601

Conversation

jchenDevops
Copy link
Contributor

@jchenDevops jchenDevops commented Nov 5, 2024

Describe your changes

Option to enable or disable OMS agent(Azure Monitor) add-on

Issue number

#600

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@jchenDevops
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Signal 1 AI"]

@jchenDevops
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Signal 1 AI"

@lonegunmanb
Copy link
Member

Hi @jchenDevops thanks for opening this pr to us! I have a question for this pr, why don't set var.log_analytics_workspace_enabled to false if you don't want oms_agent?

@jchenDevops
Copy link
Contributor Author

Hi @lonegunmanb,
If set var.log_analytics_workspace_enabled to false, defender cannot be enabled.
https://github.com/Azure/terraform-azurerm-aks/blob/main/main.tf#L462-L468

@lonegunmanb lonegunmanb changed the base branch from main to add-oms-agent-enabled December 2, 2024 05:32
@lonegunmanb lonegunmanb merged commit 59ede24 into Azure:add-oms-agent-enabled Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants