Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical Update on Storage Module #70

Merged
merged 40 commits into from
May 24, 2024
Merged

Critical Update on Storage Module #70

merged 40 commits into from
May 24, 2024

Conversation

chinthakaru
Copy link
Collaborator

@chinthakaru chinthakaru commented Apr 8, 2024 •
edited
Loading

Description

Type of Change

  • [ x] Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • [ x] Update to documentation

Checklist

  • [ x] I'm sure there are no other open Pull Requests for the same update/change
  • [x ] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [x ] I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 8, 2024
@chinthakaru chinthakaru changed the title Updating the Azuread flag on readme.md Critical Update on Storage Module May 24, 2024
@chinthakaru chinthakaru merged commit 8a9ccef into main May 24, 2024
13 checks passed
@chinthakaru chinthakaru deleted the fix-readme branch May 24, 2024 11:38
ghost
ghost reviewed May 29, 2024
View reviewed changes
outputs.tf
@@ -50,6 +45,11 @@ output "resource" {
value = azurerm_storage_account.this
}

output "resource_id" {
Copy link

@ghost ghost May 29, 2024 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@kewalaka kewalaka mentioned this pull request Jun 2, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF approved these changes

Assignees
No one assigned
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinthakaru @matt-FFFFFF @jaredfholgate