Type changed for envelopeResult from getLroMetadata

[tadelesh]

When calling getLroMetadata for createOrUpdate for the template resource, I got logicResult with right TypeSpec type Product, but envelopResult with a wrong calculated TypeSpec type ProxyResource as follow screenshot.
After some investigation, I found the type is changed after calling getEffectiveModelType here. Since the resource model has a path parameter, so it will enter the logic of finding a naming model which is same to the resource model without this path parameter (filter logic). When it has no exactly same model, it will also find a model that is same with it with the same filter logic, then the final result will fall to the original model. But after the complicated process, the type has totally changed and the naming info lost, it make the emitter hard to distinguish if it is the same resource model. Either fix the getEffectiveModelType logic for templated model or change the logic of getLroMetadata coudl resolve it. I don't know whether it should be opened as a core compiler problem or a getLroMetadata problem, If wrong place, I could move it.

[markcowl]

@tadelesh I think this is by design, the finalEnvelopeResult (which matches the finalResult) is the value that should be used by emitters. The operations in the attached specs are a bit strange, as the interface template instantiates them without using TResource, which might be a factor in why the odd result, but the finalResult/finalEnvelopeResult/finalPath should be definitive, regardless.

[tadelesh]

Let me explain more clearly. The main problem here is for the following TypeSpec, when we call getEffectiveModelType, we will get the result type with same structure with Product, but another type with wrong name ProxyResource. I suppose it should return the type of Product.

model Product is ProxyResource<ProductProperties> {
  @doc("Name of product.")
  @pattern("^[\\w][\\w\\s]{1,48}[\\w]$|^\\.default$|^\\.unassigned$")
  @key("productName")
  @path
  @segment("products")
  name: string;
}

[tadelesh]

Let me explain more clearly. The main problem here is for the following TypeSpec, when we call getEffectiveModelType, we will get the result type with same structure with Product, but another type with wrong name ProxyResource. I suppose it should return the type of Product.

model Product is ProxyResource<ProductProperties> {
  @doc("Name of product.")
  @pattern("^[\\w][\\w\\s]{1,48}[\\w]$|^\\.default$|^\\.unassigned$")
  @key("productName")
  @path
  @segment("products")
  name: string;
}

@timotheeguerin do you think it is a bug for getEffectiveModelType?

[markcowl]

This should be handled by the fix here: #1416

Closing as duplicate