Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] remove deprecated .nameInClient #446

Closed
iscai-msft opened this issue Mar 19, 2024 · 0 comments · Fixed by #1064
Closed

[tcgc] remove deprecated .nameInClient #446

iscai-msft opened this issue Mar 19, 2024 · 0 comments · Fixed by #1064
Assignees
@iscai-msft
Labels
deprecation A previously supported feature will now report a warning and eventually be removed lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@iscai-msft
Copy link
Contributor

In PR #445 we are renaming the .nameInClient property into .name on SdkModelPropertyTypes. We want to make sure we delete this deprecated property. We can be more aggressive with breaking changes bc this is more of an internal library
@iscai-msft iscai-msft added lib:tcgc Issues for @azure-tools/typespec-client-generator-core library getAllModels labels Mar 19, 2024
@iscai-msft iscai-msft self-assigned this Mar 19, 2024
@tadelesh tadelesh added the deprecation A previously supported feature will now report a warning and eventually be removed label Jun 11, 2024
@iscai-msft iscai-msft mentioned this issue Jun 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 24, 2024
@iscai-msft
[tcgc] remove deprecated nameInClient property from `SdkModelProper…
ee6fc40 
…tyType`s (#1064)

fixes #446

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
markcowl pushed a commit to markcowl/typespec-azure that referenced this issue Jun 26, 2024
@iscai-msft @markcowl
[tcgc] remove deprecated nameInClient property from `SdkModelProper…
c4a4d08 
…tyType`s (Azure#1064)

fixes Azure#446

---------

Co-authored-by: iscai-msft <isabellavcai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iscai-msft iscai-msft

Labels
deprecation A previously supported feature will now report a warning and eventually be removed lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tcgc] remove deprecated nameInClient property from SdkModelPropertyTypes Azure/typespec-azure
3 participants
@timotheeguerin @tadelesh @iscai-msft