location type should be azureLocation instead of string

[live1206]

resolves #1138

[azure-sdk]

All changed packages have been documented.

• ✅ @azure-tools/typespec-azure-resource-manager

Show changes

@azure-tools/typespec-azure-resource-manager - fix ✏️

LocationResourceParameter should be azureLocation instead of string

[azure-sdk]

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1139/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1139/

[timotheeguerin]

looks liek the ci need to regen the common types pnpm regen-samples

[live1206]

looks liek the ci need to regen the common types pnpm regen-samples

@timotheeguerin pnpm regen-samples is failing for me as below, is there any existing issue or am I missing any step here?

│  ❯ |azure-samples| test/samples.test.ts  (53 tests | 16 failed) 48112ms
│    ❯ test/samples.test.ts > TypeSpec Azure Samples > Azure Resource Manager > arm-library
│      → Unexpected diagnostics:
│ C:/src/typespec-azure/packages/typespec-azure-resource-manager/lib/private.decorators.tsp:76:12 - error missing-implementation: Extern declaration must have an implementation in JS file.
│    ❯ test/samples.test.ts > TypeSpec Azure Samples > Azure Resource Manager > contoso
│      → Unexpected diagnostics:
│ C:/src/typespec-azure/packages/typespec-azure-resource-manager/lib/private.decorators.tsp:76:12 - error missing-implementation: Extern declaration must have an implementation in JS file.
│    ❯ test/samples.test.ts > TypeSpec Azure Samples > Azure Resource Manager > legacy/managed-identity
│      → Unexpected diagnostics:
│ C:/src/typespec-azure/packages/typespec-azure-resource-manager/lib/private.decorators.tsp:76:12 - error missing-implementation: Extern declaration must have an implementation in JS file.
│    ❯ test/samples.test.ts > TypeSpec Azure Samples > Azure Resource Manager > operations/nobody-action
│      → Unexpected diagnostics:
│ C:/src/typespec-azure/packages/typespec-azure-resource-manager/lib/private.decorators.tsp:76:12 - error missing-implementation: Extern declaration must have an implementation in JS file.

I had a look at the file

So, seems like there is an existing issue here?

[timotheeguerin]

regen samples is run as part of the CI so highly doubt there is an issue, have you built the entire repo following the CONTRIBUTING guide

[allenjzhang]

#1138

[live1206]

regen samples is run as part of the CI so highly doubt there is an issue, have you built the entire repo following the CONTRIBUTING guide

I did this a while ago, need to do it again, and the samples are updated now.

[timotheeguerin]

@allenjzhang does this looks good to you , the openapi2 change is technically equivalent but we are addding extra root references

[live1206]

@allenjzhang If you don't have any objection on this, I will merge this PR tomorrow.