-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networksecurityperimeter and managedidentitywithdelegation common types #1505
Merged
AlitzelMendez
merged 17 commits into
Azure:main
from
AlitzelMendez:almend/AddCommonTypes
Oct 3, 2024
Merged
Add networksecurityperimeter and managedidentitywithdelegation common types #1505
AlitzelMendez
merged 17 commits into
Azure:main
from
AlitzelMendez:almend/AddCommonTypes
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlitzelMendez
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
September 10, 2024 18:47
All changed packages have been documented.
Show changes
|
packages/samples/common-types/openapi/v5/networksecurityperimeter.json
Outdated
Show resolved
Hide resolved
packages/samples/common-types/openapi/v5/networksecurityperimeter.json
Outdated
Show resolved
Hide resolved
You can try these changes here
|
markcowl
requested changes
Sep 12, 2024
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Show resolved
Hide resolved
… update documentation
markcowl
requested changes
Sep 17, 2024
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Outdated
Show resolved
Hide resolved
markcowl
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending resolution of the two remaining issues
packages/typespec-azure-resource-manager/lib/common-types/network-security-perimeter.tsp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #1160