[tcgc] linter raise for encoding mfd bytes #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar,
joheredi,
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented! |
srnagar
approved these changes
Feb 5, 2024
| @service({title: "Test Service"}) namespace TestService; | ||
| model EncodedBytesMFD { | ||
| @encode("base64") | ||
| pictures: bytes; |
There was a problem hiding this comment.
I think this is not necessarly true that this is invalid. What it would mean is that the part is now serialized as a base64 text/plain
There was a problem hiding this comment.
We talked about it offline and @lmazuel says that is really a corner case of MFD in HTTP. If they want base64, why not accept a JSON body. The DPG team is in agreement that at least for now we'll error out, so we don't shoot ourselves in the foot for the future
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/220/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/220/ |
added 3 commits
February 5, 2024 14:54
joheredi
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.