Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have separate datetime types #295

Merged
merged 5 commits into from
Feb 23, 2024
Merged

have separate datetime types #295

merged 5 commits into from
Feb 23, 2024

Conversation

iscai-msft
Copy link
Contributor

fixes #75

@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/295/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/295/

@iscai-msft iscai-msft enabled auto-merge (squash) February 22, 2024 23:24
timotheeguerin
timotheeguerin approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you will just go with the breaking change?

@iscai-msft iscai-msft merged commit 315ab0c into main Feb 23, 2024
14 checks passed
@iscai-msft iscai-msft deleted the utc_info branch February 23, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@daviwil daviwil Awaiting requested review from daviwil

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tcgc needs to expose if a time is UTC or not
3 participants
@iscai-msft @azure-sdk @timotheeguerin