give a nonredundant name for templated instance model #393
Conversation
tadelesh
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented. |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/393/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/393/ |
| "OperationState", | ||
| "Error", | ||
| "InnerError", | ||
| "ExportedUser", | ||
| "ErrorResponse", | ||
| "OperationStatus", | ||
| "OperationStatusExportedUserError", |
There was a problem hiding this comment.
i believe these are both core models, correct?
nit: I don't think we should modify the names of core models based off of templating. Not the biggest issue though, bc ideally no one should be generating with core models. If it makes the code much harder, no need to change your existing code
There was a problem hiding this comment.
AFAIK, OperationStatus is exported in Java and .NET. I don't think this will only happen for core model. This will happen when implicitly using templated model without @friendlyName in templated operation. And it is a possible usage for customer. Since .NET and Java need this nonredundant naming insurance, I prefer to add it in TCGC.
resolve: #334