Fixing correct name for managed identity and customer managed key, updated enum to union #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated enum to union
allenjzhang
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
|
All changed packages have been documented. |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/400/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/400/ |
packages/typespec-azure-resource-manager/src/private.decorators.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
…s.ts Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
…zhang_fixManagedIdentity
…zhang_fixManagedIdentity
…zhang/typespec-azure into azhang_fixManagedIdentity
packages/typespec-azure-resource-manager/src/private.decorators.ts
Outdated
Show resolved
Hide resolved
markcowl
reviewed
Apr 9, 2024
packages/typespec-azure-resource-manager/lib/arm.foundations.tsp
Outdated
Show resolved
Hide resolved
markcowl
reviewed
Apr 9, 2024
|
/azp run |
|
Pull request contains merge conflicts. |
They are separate. I will get this one in first and then ProvisioningState. |
…zhang_fixManagedIdentity
…zhang_fixManagedIdentity
.chronus/changes/azhang_fixManagedIdentity-2024-2-11-13-47-14.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
…zhang/typespec-azure into azhang_fixManagedIdentity
timotheeguerin
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #278