Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent carry over for @clientName #412

Merged
merged 6 commits into from
Mar 13, 2024
Merged

prevent carry over for @clientName #412

merged 6 commits into from
Mar 13, 2024

Conversation

tadelesh
Copy link
Member

resolve: #233

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 13, 2024

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

- "@azure-tools/typespec-client-generator-core"
---

prevent carry over for @clientName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prevent carry over for @clientName
prevent carry over for `@clientName`

make sure you wrap decorator as this is markdown and in github it will tag the user of that name otherwise

@@ -818,6 +821,25 @@ export function $clientName(
value: string,
scope?: LanguageScopes
) {
if (entity.kind === "Model" || entity.kind === "Operation") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a reference to this issue microsoft/typespec#2717

that this is a workaround for the lack of functionality in the compiler.

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @tadelesh just left some small comments should be good to merge after

@iscai-msft iscai-msft enabled auto-merge (squash) March 13, 2024 15:50
@iscai-msft iscai-msft merged commit a54de8f into main Mar 13, 2024
14 checks passed
@iscai-msft iscai-msft deleted the prevent-carry-over branch March 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@clientName shouldn't carry over
4 participants