-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent carry over for @clientName
#412
Conversation
All changed packages have been documented. |
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/412/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/412/ |
- "@azure-tools/typespec-client-generator-core" | ||
--- | ||
|
||
prevent carry over for @clientName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prevent carry over for @clientName | |
�prevent carry over for `@clientName` |
make sure you wrap decorator as this is markdown and in github it will tag the user of that name otherwise
@@ -818,6 +821,25 @@ export function $clientName( | |||
value: string, | |||
scope?: LanguageScopes | |||
) { | |||
if (entity.kind === "Model" || entity.kind === "Operation") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a reference to this issue microsoft/typespec#2717
that this is a workaround for the lack of functionality in the compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks @tadelesh just left some small comments should be good to merge after
resolve: #233