-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made delegatedIdentityClientId
optional CustomerManagedKeyEncryption
to align with the common types definition
#495
Conversation
All changed packages have been documented. |
.chronus/changes/alexbat/alexbat-delegatedIdentityClientId-1-2024-3-21-20-6.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to change now as tt should not be breaking the provider hub controller generation as long as the type was generated as a string. With the new change to allow to generate as Guid now the property would be shown differently.
@markcowl let me know if you agree on that
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/495/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/495/ |
ab3bb72
to
c97ea2d
Compare
delegatedIdentityClientId
optional CustomerManagedKeyEncryption
to align with the common types definition
@timotheeguerin would I need to submit one more PR to update the pr/providerhub branch? |
in what way? this one + your other to allow Guid generation should be good, and next release everthing works |
Sounds good! The build fails because I crafted the change log file manually. Will fix it on Wednesday (once back home, right now I have only my phone) until you'd have a moment and update my branch with a correct file (idk why exactly it didn't like the one I made). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - you will need to regenerate the docs by running a repo-wide build (pnpm build), or you can run the task froo regenerating docs directly for just the ARM library (cd packages/typespec-azure-resource-manager; pnpm regen-docs)
10028c0
to
07b93b4
Compare
8c55d8f
to
09d4019
Compare
@markcowl done. and the build is green. |
Resolves #428.