-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Exempt versioning enums and discriminator enum/unions from documentation required rule #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
force-pushed
the
rules/addEnumDocExceptions
branch
from
April 19, 2024 22:21
0cf9f40
to
59aadf1
Compare
All changed packages have been documented.
Show changes
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/710/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/710/ |
tjprescott
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
April 22, 2024 18:01
tjprescott
force-pushed
the
rules/addEnumDocExceptions
branch
from
April 22, 2024 18:01
671154c
to
3a47dbc
Compare
.chronus/changes/rules-addEnumDocExceptions-2024-3-19-22-29-42.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
tjprescott
force-pushed
the
rules/addEnumDocExceptions
branch
from
April 24, 2024 16:45
939a64c
to
1e1c73a
Compare
timotheeguerin
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Azure/typespec-azure-pr/issues/3107
After merging, I will make a PR to clean up the suppressions in the REST API specs repo.