Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint from 8.57.0 to 9.9.0 in /webview-ui #862

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 19, 2024

Bumps eslint from 8.57.0 to 9.9.0.

Release notes

Sourced from eslint's releases.

v9.9.0

Features

  • 41d0206 feat: Add support for TS config files (#18134) (Arya Emami)
  • 3a4eaf9 feat: add suggestion to require-await to remove async keyword (#18716) (Dave)

Documentation

  • 9fe068c docs: how to author plugins with configs that extend other configs (#18753) (Alec Gibson)
  • 48117b2 docs: add version support page in the side navbar (#18738) (Amaresh S M)
  • fec2951 docs: add version support page to the dropdown (#18730) (Amaresh S M)
  • 38a0661 docs: Fix typo (#18735) (Zaina Al Habash)
  • 3c32a9e docs: Update yarn command for creating ESLint config (#18739) (Temitope Ogunleye)
  • f9ac978 docs: Update README (GitHub Actions Bot)

Chores

  • 461b2c3 chore: upgrade to @eslint/js@9.9.0 (#18765) (Francesco Trotta)
  • 59dba1b chore: package.json update for @​eslint/js release (Jenkins)
  • fea8563 chore: update dependency @​eslint/core to ^0.3.0 (#18724) (renovate[bot])
  • aac191e chore: update dependency @​eslint/json to ^0.3.0 (#18760) (renovate[bot])
  • b97fa05 chore: update wdio dependencies for more stable tests (#18759) (Christian Bromann)

v9.8.0

Features

  • 13d0bd3 feat: Add and use SourceCode#getLoc/getRange (#18703) (Nicholas C. Zakas)

Bug Fixes

  • ab0ff27 fix: Throw error when invalid flags passed (#18705) (Nicholas C. Zakas)
  • 70dc803 fix: basePath directory can never be ignored (#18711) (Milos Djermanovic)

Documentation

Build Related

  • 4514424 build: Enable JSON linting (#18681) (Nicholas C. Zakas)

Chores

  • deee448 chore: upgrade to @eslint/js@9.8.0 (#18720) (Francesco Trotta)
  • 4aaf2b3 chore: package.json update for @​eslint/js release (Jenkins)
  • 8e1a627 chore: update dependency @​eslint/core to ^0.2.0 (#18700) (renovate[bot])

v9.7.0

Features

  • 7bd9839 feat: add support for es2025 duplicate named capturing groups (#18630) (Yosuke Ota)
  • 1381394 feat: add regex option in no-restricted-imports (#18622) (Nitin Kumar)

Bug Fixes

  • 14e9f81 fix: destructuring in catch clause in no-unused-vars (#18636) (Francesco Trotta)

Documentation

... (truncated)

Changelog

Sourced from eslint's changelog.

v9.9.0 - August 9, 2024

  • 461b2c3 chore: upgrade to @eslint/js@9.9.0 (#18765) (Francesco Trotta)
  • 59dba1b chore: package.json update for @​eslint/js release (Jenkins)
  • fea8563 chore: update dependency @​eslint/core to ^0.3.0 (#18724) (renovate[bot])
  • 41d0206 feat: Add support for TS config files (#18134) (Arya Emami)
  • aac191e chore: update dependency @​eslint/json to ^0.3.0 (#18760) (renovate[bot])
  • 9fe068c docs: how to author plugins with configs that extend other configs (#18753) (Alec Gibson)
  • b97fa05 chore: update wdio dependencies for more stable tests (#18759) (Christian Bromann)
  • 3a4eaf9 feat: add suggestion to require-await to remove async keyword (#18716) (Dave)
  • 48117b2 docs: add version support page in the side navbar (#18738) (Amaresh S M)
  • fec2951 docs: add version support page to the dropdown (#18730) (Amaresh S M)
  • 38a0661 docs: Fix typo (#18735) (Zaina Al Habash)
  • 3c32a9e docs: Update yarn command for creating ESLint config (#18739) (Temitope Ogunleye)
  • f9ac978 docs: Update README (GitHub Actions Bot)

v9.8.0 - July 26, 2024

  • deee448 chore: upgrade to @eslint/js@9.8.0 (#18720) (Francesco Trotta)
  • 4aaf2b3 chore: package.json update for @​eslint/js release (Jenkins)
  • 8e1a627 chore: update dependency @​eslint/core to ^0.2.0 (#18700) (renovate[bot])
  • 13d0bd3 feat: Add and use SourceCode#getLoc/getRange (#18703) (Nicholas C. Zakas)
  • 282df1a docs: Add system theme option (#18617) (Amaresh S M)
  • ab0ff27 fix: Throw error when invalid flags passed (#18705) (Nicholas C. Zakas)
  • 70dc803 fix: basePath directory can never be ignored (#18711) (Milos Djermanovic)
  • 53b1ff0 docs: Debug config docs (#18698) (Nicholas C. Zakas)
  • 4514424 build: Enable JSON linting (#18681) (Nicholas C. Zakas)
  • a7016a5 docs: fix search input stylings (#18682) (Amaresh S M)

v9.7.0 - July 12, 2024

  • 793b718 chore: upgrade @​eslint/js@​9.7.0 (#18680) (Francesco Trotta)
  • 7ed6f9a chore: package.json update for @​eslint/js release (Jenkins)
  • 14e9f81 fix: destructuring in catch clause in no-unused-vars (#18636) (Francesco Trotta)
  • 7bcda76 refactor: Add type references (#18652) (Nicholas C. Zakas)
  • 51bf57c chore: add tech sponsors through actions (#18624) (Strek)
  • 9f416db docs: Add Powered by Algolia label to the search. (#18633) (Amaresh S M)
  • 6320732 refactor: don't use parent property in NodeEventGenerator (#18653) (Milos Djermanovic)
  • 7bd9839 feat: add support for es2025 duplicate named capturing groups (#18630) (Yosuke Ota)
  • 1381394 feat: add regex option in no-restricted-imports (#18622) (Nitin Kumar)
  • 9e6d640 refactor: move "Parsing error" prefix adding to Linter (#18650) (Milos Djermanovic)
  • c8d26cb docs: Open JS Foundation -> OpenJS Foundation (#18649) (Milos Djermanovic)
  • 6e79ac7 docs: loadESLint does not support option cwd (#18641) (Francesco Trotta)

v9.6.0 - June 28, 2024

  • b15ee30 chore: upgrade @​eslint/js@​9.6.0 (#18632) (Milos Djermanovic)
  • d655503 chore: package.json update for @​eslint/js release (Jenkins)
  • 1613e2e fix: Allow escaping characters in config patterns on Windows (#18628) (Milos Djermanovic)
  • 13dbecd docs: Limit search to just docs (#18627) (Nicholas C. Zakas)

... (truncated)

Commits
  • 0dd3863 9.9.0
  • 2e5ba77 Build: changelog update for 9.9.0
  • 461b2c3 chore: upgrade to @eslint/js@9.9.0 (#18765)
  • 59dba1b chore: package.json update for @​eslint/js release
  • fea8563 chore: update dependency @​eslint/core to ^0.3.0 (#18724)
  • 41d0206 feat: Add support for TS config files (#18134)
  • aac191e chore: update dependency @​eslint/json to ^0.3.0 (#18760)
  • 9fe068c docs: how to author plugins with configs that extend other configs (#18753)
  • b97fa05 chore: update wdio dependencies for more stable tests (#18759)
  • 3a4eaf9 feat: add suggestion to require-await to remove async keyword (#18716)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 19, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/webview-ui/eslint-9.9.0 branch from 10d995f to ec29354 Compare August 19, 2024 22:35
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.9.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.9.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/webview-ui/eslint-9.9.0 branch from ec29354 to ddc0a21 Compare August 19, 2024 22:35
@Tatsinnit
Copy link
Member

Tatsinnit commented Aug 20, 2024

This seems like major breaking change: https://eslint.org/docs/latest/use/migrate-to-9.0.0

More context here: typescript-eslint/typescript-eslint#8766

Thanks.

@tejhan
Copy link
Collaborator

tejhan commented Aug 22, 2024

The issue seems to be that Dependabot attempted to upgrade eslint from 8.57 to 9.9 in the webview folder, but "eslint-plugin-react-hooks" (v 4.6.2) doesn't support eslint v9 as of yet (facebook/react#28773).

Thus, there is a peer dependency issue between the two, which caused unresolved errors during the build.

We will keep v8 of eslint until eslint-plugin-react-hooks supports v9 in a future stable release.

@tejhan tejhan closed this Aug 22, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/webview-ui/eslint-9.9.0 branch August 22, 2024 15:21
@tejhan tejhan self-assigned this Aug 22, 2024
@tejhan tejhan restored the dependabot/npm_and_yarn/webview-ui/eslint-9.9.0 branch August 22, 2024 15:37
@tejhan tejhan reopened this Aug 22, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 26, 2024

Superseded by #885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants