Add TVP to check if Token Identifier can be logged #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruke
force-pushed
the
sruthi/LogTokenId
branch
from
d619ab5 to
8a3c81a
Compare
|
Should Wilson log any message when the TokenValidationParameter.LogTokenId is true, or this is only for SAL to use? |
Right now, only the TokenValidationParameter (TVP) is getting introduced in Wilson. No action will be taken in Wilson based on the value. I will create a GitHub issue to log the Token Identifier in Wilson based on the TVP value. |
dannybtsai
approved these changes
Jan 18, 2023
TimHannMSFT
approved these changes
Jan 19, 2023
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Jan 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [System.IdentityModel.Tokens.Jwt](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) | nuget | minor | `6.25.1` -> `6.26.0` | --- ### Release Notes <details> <summary>AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet</summary> ### [`v6.26.0`](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.26.0) [Compare Source](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.25.1...6.26.0) Servicing release Introducing a new boolean TokenValidationParameter LogTokenId. [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2002](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2002) Update System.Text.Encodings.Web [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1997](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1997) Update ValidateToken call stack fully async [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1996](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1996) JsonWebTokenHandler to return the JsonWebToken on validation failure [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1989](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1989) Update documentation of DefaultTokenLifetimeInMinutes [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1988](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1988) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDkuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOS4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Mar 28, 2023
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changing?
Introducing a new boolean TokenValidationParameter LogTokenId. By default, it set to true.
Why?
It will allow the library to log a token identifier if LogTokenId is set to true.
Note: Today, no action will be taken in Wilson based on the value of LogTokenId.