Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Task to ValueTask. #2287

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Change Task to ValueTask. #2287

merged 1 commit into from
Sep 5, 2023

Conversation

brentschmaltz
Copy link
Member

We will have to coordinate this with other changes as Task is expected in some call graphs.

@keegan-caruso
Copy link
Contributor

if you want to go this route we have to revert these changes as well:

azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Tokens/Validators.cs

Line 218 in 5c9192c

ValueTask<string> vt = ValidateIssuerAsync(issuer, securityToken, validationParameters, configuration);

@brentschmaltz brentschmaltz force-pushed the brentsch/ValueTask7 branch 2 times, most recently from ba7d1b8 to 6d4659a Compare September 4, 2023 20:53
@brentschmaltz
Copy link
Member Author

@keegan-caruso you make a good point, it will be easier to make a single change in AadIssuerValidator.

@brentschmaltz brentschmaltz changed the title switch back to Task from ValueTask. Change Task to ValueTask. Sep 4, 2023
@jmprieur
Copy link
Contributor

jmprieur commented Sep 5, 2023

Is it a breaking change for SAL? IdWeb?

@jennyf19 jennyf19 added this to the 7.0.0-preview5 milestone Sep 5, 2023
@brentschmaltz brentschmaltz added this pull request to the merge queue Sep 5, 2023
Merged via the queue into dev7 with commit 719b3c0 Sep 5, 2023
brentschmaltz added a commit that referenced this pull request Sep 6, 2023
@brentschmaltz
AddIssuerValidator return ValueTask. (#2287)
152b9e8 
Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
@brentschmaltz brentschmaltz deleted the brentsch/ValueTask7 branch September 6, 2023 17:58
brentschmaltz added a commit that referenced this pull request Sep 7, 2023
@brentschmaltz
AddIssuerValidator return ValueTask. (#2287)
22f23d0 
Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
This was referenced Sep 11, 2023
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 21, 2024
Open
Open
Open
Closed
Merged
Closed
Open
Open
Open
This was referenced Jan 29, 2024
Closed
Closed
Closed
Closed
Closed
Open
@dependabot dependabot bot mentioned this pull request Mar 4, 2024
Open
@dependabot dependabot bot mentioned this pull request May 1, 2024
Closed
This was referenced Aug 1, 2024
Closed
Open
This was referenced Aug 19, 2024
Closed
Closed
Closed
Merged
Merged
Open
This was referenced Nov 11, 2024
Closed
Closed
@dependabot dependabot bot mentioned this pull request Nov 25, 2024
Closed
This was referenced Dec 2, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westin-m westin-m westin-m approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0-preview5
Development

Successfully merging this pull request may close these issues.
5 participants
@brentschmaltz @keegan-caruso @jmprieur @jennyf19 @westin-m