Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XML comments for clarity in Microsoft.IdentityModel.Tokens #2678

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Refactor XML comments for clarity in Microsoft.IdentityModel.Tokens #2678

merged 6 commits into from
Jul 8, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Jul 2, 2024 •
edited
Loading

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This PR enhances the XML documentation across Microsoft.IdentityModel.Tokens. This is the first part for this assembly, I'll propose other changes later when I have the time.

@joegoldman2 joegoldman2 requested a review from a team as a code owner July 2, 2024 14:18
@brentschmaltz
Copy link
Member

@joegoldman2 really great improvements here.
Thanks.

brentschmaltz
brentschmaltz approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice cleanup!

@brentschmaltz brentschmaltz merged commit 0fd8362 into AzureAD:dev Jul 8, 2024
1 check passed
@joegoldman2 joegoldman2 deleted the xml-doc-tokens branch July 9, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joegoldman2 @brentschmaltz