Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use fxcop in netfw #2693

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

keegan-caruso
Copy link
Contributor

Only use fxcop in netfw

Description

Fx Cop should only be used in net framework targets

@keegan-caruso keegan-caruso requested a review from a team as a code owner July 10, 2024 00:37
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -65,4 +65,11 @@
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="$(MicrosoftSourceLinkGitHubVersion)" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use FxCop at all? Thought it was deprecated. Normal Roslyn analyzers should work on .NET Fx?

@keegan-caruso keegan-caruso force-pushed the kecaruso/only-use-fxcop-in-netfw branch 2 times, most recently from 13d2eab to 271e55e Compare July 22, 2024 18:03
@brentschmaltz brentschmaltz force-pushed the kecaruso/only-use-fxcop-in-netfw branch from 271e55e to 7bfa839 Compare July 24, 2024 23:39
@brentschmaltz brentschmaltz merged commit 4a34fa7 into dev Jul 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants