ValidateTokenAsync: New code path #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateJWEAsync Added InternalTokenValidationResult to hold the intermediate validation results. Moved result types to their own folder. Removed unused delegate from TokenValidationParameters
iNinja
requested review from
GeoK,
brentschmaltz,
FuPingFranco and
keegan-caruso
| string token, | ||
| ValidationParameters validationParameters, | ||
| CallContext callContext, | ||
| CancellationToken? cancellationToken) |
There was a problem hiding this comment.
should we allow this to be null?
There was a problem hiding this comment.
For now I have kept it optional and assigned CancellationToken.None if it is not present.
We can make this mandatory over the next weeks if we think it is worth enforcing.
| return new TokenValidationResult { Exception = LogHelper.LogArgumentNullException(nameof(validationParameters)), IsValid = false }; | ||
|
|
||
| if (token.Length > MaximumTokenSizeInBytes) | ||
| return new TokenValidationResult { Exception = LogHelper.LogExceptionMessage(new ArgumentException(LogHelper.FormatInvariant(TokenLogMessages.IDX10209, LogHelper.MarkAsNonPII(token.Length), LogHelper.MarkAsNonPII(MaximumTokenSizeInBytes)))), IsValid = false }; |
There was a problem hiding this comment.
please stack these parameters.
| /// <exception cref="ArgumentNullException"></exception> | ||
| public InternalTokenValidationResult(SecurityToken? securityToken, TokenHandler tokenHandler) | ||
| { | ||
| _securityToken = securityToken; |
There was a problem hiding this comment.
Why should securityToken be allowed to be null?
There was a problem hiding this comment.
Because there are cases such as validating a token from a string where the reading / decrypting can fail and we end up without a security token, and yet we need to return a result to indicate what went wrong.
brentschmaltz
approved these changes
Aug 13, 2024
FuPingFranco
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidateTokenAsync: New code path
Join all the refactored validators into a new
ValidateTokenAsyncentry point.Description
Tests to be added before marking ready for review.
Creation of
ClaimsIdentitystill needs a resolution, as the current implementation inTokenValidationResultusesTokenValidationParameters.Part of #2711