Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to the new validation model #3054

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Dec 6, 2024

Add logging to the new validation model

This PR introduces .NET's high performance logging to the new validation model.
The aim is to provide a way to log the results after the fact and on demand, instead of logging as we perform the validation.

  • Added Microsoft.Extensions.Logging.Abstractions to Microsoft.IdentityModel.Tokens to access ILogger (version 9.0.0 does not explicitly support dotnet6, so I am using 8.0.2)
  • Added LoggingEventIds to store event ids used by the logging methods in M.IM.Tokens
  • Added logging to ValidationError and ValidatedToken to log the results obtained from ValidateTokenAsync

Part of #2711

@iNinja iNinja requested a review from a team as a code owner December 6, 2024 16:58
Copy link
Contributor

@kellyyangsong kellyyangsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@iNinja iNinja merged commit 853b1fb into dev Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants