This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Change scope of UserAuthType from internal to public #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that UserCredential can ba overridden in .NET Core library, eg) UserPasswordCredential - regarding to the issue AzureAD#482
|
Hi @justinyoo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
This scenario is not supported by design. We want developers to move away from resource owner grant flows. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Team.
Regarding to the issue #482 , I changed the scope of the enum
UserAuthTypefrom internal to public. With this change, theUserCredentialclass can be inherited for .NET Core application, likeUserPasswordCredential, which only supports .NET full framework.It would be great if you review this change and accept it.
Cheers,