This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
[client certificate]: support Subject Name + Issuer authentications #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting some offline discussion here.
- To generate key pairs, you can use openssl, e.g.
openssl req -x509 -nodes -newkey rsa:2048 -keyout key.pem -out cert.pem -days 365
- For what it's worth, the
jwt.encode({...}, a_combined_key, ...)
we used also accepts a private+public combined key file, and it will choose the private to do the encoding. However we decide to keep the private key and public key as 2 separated input parameter from the beginning, rather than relying on external logic to extract the public key from the combined input. - The agreed naming
public_certificate
(rather thansend_x5c
) was also proposed before in ADAL .Net
This PR looks straightforward! Thanks @yugangw-msft ! Feel free to "add test coverage" (as you mentioned in PR description). I'm sending the PR review approval right now. :-)
rayluo
changed the title
[client certificate]: support sn+issuer authentications
[client certificate]: support Subject Name + Issuer authentications
Oct 18, 2018
Also documenting the backgroud of this SubjectName/Issuer Authentication feature. The workflow would look like:
|
Merged
Looks Good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum change. Naming and logic are chosen based on dotnet version.
Once the mechanism is approved, i will add test coverage