This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADAL Python 1.2.1
Don't skip __ne__ in Python 2, per https://stackoverflow.com/questions/4352244/python-should-i-implement-ne-operator-based-on-eq
Add __ne__() in TokenCacheKey
Update requirements.txt to use approved versions
Remove inaccurate RE, use plain string searching instead
Updated some links to https
Change info to debug for message
* Changed info log level to debug log level for debug logs * Update token_request.py Per request of markmabe: #197 (comment)
* Reword the ValueError text when tenant is not right * Have to adjust test case too * Addressing PR review comments
Usability enhancement in Subject Name and Issuer Authentication input
Bumping version number
abhidnya13
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the sub-PRs included in this release has been tested and reviewed and approved in their individual PR. The purpose of this all-in-one release PR is to organize the release process. Please review/proof-read the following release notes.
Release Notes:
-----BEGIN CERTIFICATE-----
tag lines. (acquire_token_with_client_certificate with public cert failing #199, Usability enhancement in Subject Name and Issuer Authentication input #207)If you want to have a hands-on test, you can grab this release candidate by:
This PR will close #122