This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Federated flow fix #240
Merged
Federated flow fix #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
approved these changes
Sep 17, 2020
|
Tested the flows with WW authority and they work fine. Merging this in. |
rayluo
reviewed
Sep 21, 2020
| @@ -131,6 +132,7 @@ def _parse_discovery_response(self, body): | |||
| self.federation_protocol = protocol | |||
| self.federation_metadata_url = response['federation_metadata_url'] | |||
| self.federation_active_auth_url = response['federation_active_auth_url'] | |||
| self.cloud_audience_urn = response.get('cloud_audience_urn', "urn:federation:MicrosoftOnline") | |||
There was a problem hiding this comment.
Confirmed that this would be the same approach as what ADAL C++ does for years now.
[4:21 PM] Petar Dimov
So what ADAL Cpp does is. If we receive it from the userrealm request, we will use what we receive. Otherwise we default to urn:federation:MicrosoftOnline
[4:30 PM] Abhidnya Patil
Cpp confirmed they pull it from userrealm response, Travis : https://github.com/AzureAD/azure-activedirectory-library-for-cpp/blob/dev/src/cpp/src/lib/windows/UserRealm.cpp#L233
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing for migration of Fairfax, username-password federated was failing, this PR includes the fix.
The problem was ADAL was hardcoding Cloud_audience_urn which is now fetched from the mex response.