Fix base64 decoding to properly handle claims with unicode characters such as Japanese #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… such as Japanese
Closed
jmckennon
reviewed
Oct 7, 2019
jmckennon
approved these changes
Oct 7, 2019
pkanher617
approved these changes
Oct 8, 2019
|
Any idea when this fix will be deployed to master? |
|
@valeeum @nakawankuma Please try |
|
@jasonnutter Please release this merged! |
|
@htthao This is available in the beta version noted above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our base64 decoding was not properly handling when STS generated an id_token for a user with Japanese characters, due to unicode characters. Example id_token included as a test case.
Repro by creating a user with a name with unicode characters (such as those in the test case) and having them sign into the Vanilla JS sample.
Fixes: #985