Remove sandboxing from hidden iframe, due to change in eSTS redirect #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerag
reviewed
Oct 16, 2019
DarylThayil
reviewed
Oct 17, 2019
DarylThayil
reviewed
Oct 17, 2019
DarylThayil
approved these changes
Oct 17, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STS now performs its redirects client-side in JavaScript, meaning we can no longer sandbox hidden iframes, as it will prevent the redirect from happening at all. Added code to immediately remove the iframe once we have the hash from the url, to mitigate MSAL code rerunning in the iframe (this is similar to what we do for popups, which we also can't sandbox).
Also removed ES6 JS that wasn't working in IE11 and replaced with ES5 code.