Ensure errors thrown when monitoring window are caught and handled #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonnutter
force-pushed
the
catch-unhandled-rejections
branch
from
a9510b0 to
afaf7f8
Compare
jasonnutter
commented
Nov 14, 2019
| @@ -34,6 +34,8 @@ export default C => | |||
| return redirect | |||
| ? msalApp.acquireTokenRedirect(request) | |||
| : msalApp.acquireTokenPopup(request); | |||
| } else { | |||
| console.error('Non-interactive error:', error.errorCode) | |||
There was a problem hiding this comment.
Timeout errors were previously not bubbling up to the call site in the application.
jasonnutter
requested review from
sameerag,
DarylThayil,
pkanher617 and
jmckennon
pkanher617
approved these changes
Nov 14, 2019
jmckennon
reviewed
Nov 14, 2019
| @@ -1260,7 +1268,7 @@ export class UserAgentApplication { | |||
| this.registerCallback(serverAuthenticationRequest.state, scope, resolve, reject); | |||
| this.logger.infoPii("Navigate to:" + urlNavigate); | |||
| frameHandle.src = "about:blank"; | |||
| this.loadIframeTimeout(urlNavigate, frameName, scope); | |||
| this.loadIframeTimeout(urlNavigate, frameName, scope).catch(error => reject(error)); | |||
There was a problem hiding this comment.
is there a reason why in some places we have if (reject) after catching the error and sometimes not?
sameerag
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
monitorWindowForHashthrew an error, it wasn't properly caught, which resulted in unhandled rejection errors (and the inability for apps to catch and handle these errors on their own). This PR ensures that these errors are caught, and properly passed up to the call site that initiate the request.