Remove generated doc files from repo, deploy them to Github Pages #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll keep this as a manual step, for now. We can look at putting it into CI in a follow up PR. |
jasonnutter
requested review from
pkanher617,
jmckennon,
DarylThayil and
sameerag
|
Further follow up work will include adding lint rules to require JS Doc comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were creating a lot of churn in our PRs, so I've removed from the repo, and have them generated and pushed to Github Pages.
https://azuread.github.io/microsoft-authentication-library-for-js/docs/msal/index.html