-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Acquire Token APIs Internally #792
Conversation
what are the breaking changes? |
Might be good to schedule some time to go over this as a team, a lot of code changed and hard to ngrok it all |
There aren't any breaking changes yet, I should have edited the description. The considerations I have listed would be breaking changes depending on what we decide.
I will throw something on the calendar. |
I am not adding comments as we will go through this tomorrow in the review meetup. We need to follow this up with:
I know you are working on some PRs regarding this, I can help too, let me know and we can split up. |
…or better separation of duty
isCallback is a breaking change |
Me and @pkanher617 synced up offline and closed most review comments/follow-ups I had. We also created more internal PRs for future work to track some changes we wanted to get in later. I want to do a quick peek for a few more changes and will approve tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, feel free to merge when you close with others on their open questions / get another approval
This PR is to refactor our code for interactive acquire token calls, which will avoid repetition. There are some considerations to make here, including:
The above changes can come in separate PRs that will be released in a major version, since these will be breaking changes.
Here is a summary of changes in this PR: